Allow Service retirement over Centralized Administration #4790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrudman
force-pushed
the
allow-remote-retiement-for-service
branch
2 times, most recently
from
74fbc13 to
9bc7407
Compare
yrudman
force-pushed
the
allow-remote-retiement-for-service
branch
from
9bc7407 to
f80cb98
Compare
|
Checked commit yrudman@f80cb98 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label blocker |
yrudman
changed the title
|
\cc @gtanzillo @tinaafitz |
tinaafitz
reviewed
Oct 19, 2018
| when 'OrchestrationStack', 'Service', 'CloudObjectStoreContainer', 'CloudObjectStoreObject' | ||
| objs, _objs_out_reg = filter_ids_in_region(objs, klass.to_s) | ||
| when 'CloudObjectStoreContainer', 'CloudObjectStoreObject' | ||
| objs, _objs_out_reg = filter_ids_in_region(objs, klass_str) | ||
| when 'VmOrTemplate' |
There was a problem hiding this comment.
Hi @yrudman Why would the condition be different for VM's here?
There was a problem hiding this comment.
@tinaafitz
There are several reasons to add separate when:
Servicewould have only one available for centralized Administration task in that method -retire_nowbutVmhas much longer list of tasks available for Centralized administration and it would looks confusing to putVmandServicetogether- value in case condition and parameter passed to
filter_in_regionare different strings for Vm
gtanzillo
approved these changes
Oct 22, 2018
simaishi
pushed a commit
that referenced
this pull request
Oct 24, 2018
Allow Service retirement over Centralized Administration (cherry picked from commit c15b650) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633142
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Nov 5, 2018
Allow Service retirement over Centralized Administration (cherry picked from commit c15b650) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1643261
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: in multiregion environment attempt to retire service replicated to Global region will fail with "The selected Service is not in the current region"
This PR: allow
retire_nowtask to be processed via Centralized Administration forServiceandOrchestrationStackBEFORE:
AFTER:
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1633142
@miq-bot add-label bug, gaprindashvili/yes, hammer/yes