Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing button for showing fullscreen report from list view #4741

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Removing button for showing fullscreen report from list view #4741

merged 1 commit into from
Oct 9, 2018

Conversation

romanblanco
Copy link
Member

@romanblanco romanblanco commented Oct 8, 2018 •
edited
Loading

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1632630
Closes: #4733

response to my comment #4734 (comment).

Rather than modifying the button so it's never visible for the list view it's better to remove it completely from the toolbar

Links

Steps for Testing/QA

Cloud Intel - Reports - Saved Reports accordion

  • the "Show full screen Report" will only be available on the detail of the report

@romanblanco
Copy link
Member Author

@miq-bot assign @rvsia

@romanblanco
Copy link
Member Author

@miq-bot add_label hammer/yes
@miq-bot add_label bug
@miq-bot add_label cloud intel/reporting

@mzazrivec mzazrivec requested a review from rvsia October 9, 2018 08:06
rvsia
rvsia approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in UI. Looks great! 👍

@mzazrivec mzazrivec self-assigned this Oct 9, 2018
@mzazrivec mzazrivec added this to the Sprint 97 Ending Oct 22, 2018 milestone Oct 9, 2018
@mzazrivec mzazrivec merged commit 4b64bae into ManageIQ:master Oct 9, 2018
@romanblanco romanblanco deleted the bz1632630 branch October 9, 2018 12:12
simaishi pushed a commit that referenced this pull request Oct 9, 2018
@mzazrivec @simaishi
Merge pull request #4741 from romanblanco/bz1632630
159c755 
Removing button for showing fullscreen report from list view

(cherry picked from commit 4b64bae)

https://bugzilla.redhat.com/show_bug.cgi?id=1632630
@simaishi
Copy link
Contributor

simaishi commented Oct 9, 2018

Hammer backport details:

$ git log -1
commit 159c755c8b32b9248882d1a9bef7f2fceaa5e140
Author: Milan Zázrivec <[email protected]>
Date:   Tue Oct 9 14:04:45 2018 +0200

    Merge pull request #4741 from romanblanco/bz1632630
    
    Removing button for showing fullscreen report from list view
    
    (cherry picked from commit 4b64bae604f0ecd3c740eeb79cc412ef42f7710f)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1632630

@rvsia rvsia mentioned this pull request Nov 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvsia rvsia rvsia approved these changes

Assignees

@mzazrivec mzazrivec

@rvsia rvsia

Labels
bug hammer/backported overview/reporting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@romanblanco @simaishi @rvsia @mzazrivec @miq-bot