Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for cloud_networks and subnets #4736

Merged

Conversation

andyvesel
Copy link
Contributor

Added conditions, validating if cloud_networks and cloud_subnets are present for infra host
This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635126

@andyvesel andyvesel force-pushed the validation_for_cloud_networks_subnets branch from 8bcb285 to 86cc42f Compare October 5, 2018 14:13
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commit andyvesel@86cc42f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec self-assigned this Oct 8, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 8, 2018
@mzazrivec mzazrivec merged commit 737c42f into ManageIQ:master Oct 8, 2018
simaishi pushed a commit that referenced this pull request Oct 8, 2018
…_subnets

Add validation for cloud_networks and subnets

(cherry picked from commit 737c42f)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635126
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit c4d2baf72ee3a9825e925be5fa1de90cbc9e9d2f
Author: Milan Zázrivec <[email protected]>
Date:   Mon Oct 8 10:41:12 2018 +0200

    Merge pull request #4736 from andyvesel/validation_for_cloud_networks_subnets
    
    Add validation for cloud_networks and subnets
    
    (cherry picked from commit 737c42f60e647323278a81cb975caeb3ddea209f)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1635126

@andyvesel andyvesel deleted the validation_for_cloud_networks_subnets branch November 21, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants