Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix losing focus of the form while renaming a VM #4721

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Fix losing focus of the form while renaming a VM #4721

merged 1 commit into from
Oct 2, 2018

Conversation

hstastna
Copy link

@hstastna hstastna commented Oct 1, 2018 •
edited
Loading

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1628723

This PR fixes losing focus of the form while renaming a VM under Compute > Infra > VMs and also any VM from any nested list of VMs (for example VMs displayed thru provider's details page).

Note:
Renaming VMs is supported only for VMs of VMWare provider.

Before:
rename-before

After:
rename-after

@hstastna
Copy link
Author

hstastna commented Oct 1, 2018

@miq-bot add_label bug, hammer/yes

@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commit hstastna@53a0c8e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@hstastna hstastna changed the title [WIP] Fix losing focus of the form while renaming a VM Fix losing focus of the form while renaming a VM Oct 1, 2018
@miq-bot miq-bot removed the wip label Oct 1, 2018
@mzazrivec mzazrivec self-assigned this Oct 2, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
@mzazrivec mzazrivec merged commit f3cc8ef into ManageIQ:master Oct 2, 2018
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@mzazrivec @simaishi
Merge pull request #4721 from hstastna/Rename_VM_form_focus_typing
e615f8f 
Fix losing focus of the form while renaming a VM

(cherry picked from commit f3cc8ef)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628723
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit e615f8f23056ab27f401e2d933664d6bc392f98e
Author: Milan Zázrivec <[email protected]>
Date:   Tue Oct 2 15:24:33 2018 +0200

    Merge pull request #4721 from hstastna/Rename_VM_form_focus_typing
    
    Fix losing focus of the form while renaming a VM
    
    (cherry picked from commit f3cc8ef506110ef920ce56731dfd1e97995e5ac9)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
bug compute/infrastructure hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hstastna @miq-bot @simaishi @mzazrivec