Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put background under archived/orphaned tree node icons in VMs #4711

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Put background under archived/orphaned tree node icons in VMs #4711

merged 1 commit into from
Oct 2, 2018

Conversation

skateman
Copy link
Member

This will make the tree nodes fully consistent with the quads.

Before:
screenshot from 2018-09-27 15-57-56

After:
screenshot from 2018-09-27 15-53-43

@miq-bot add_reviewer @epwinchell
@miq-bot add_label gaprindashvili/no, hammer/yes, graphics

@miq-bot miq-bot requested a review from epwinchell September 27, 2018 13:59
epwinchell
epwinchell approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@epwinchell epwinchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Looks good.

@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2018

Checked commit skateman@300fb2f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
4 files checked, 0 offenses detected
Everything looks fine. 👍

@mzazrivec mzazrivec self-assigned this Oct 1, 2018
@mzazrivec mzazrivec added this to the Sprint 96 Ending Oct 8, 2018 milestone Oct 2, 2018
@mzazrivec mzazrivec merged commit 5fae302 into ManageIQ:master Oct 2, 2018
simaishi pushed a commit that referenced this pull request Oct 2, 2018
@mzazrivec @simaishi
Merge pull request #4711 from skateman/treeview-archorph
f300d95 
Put background under archived/orphaned tree node icons in VMs

(cherry picked from commit 5fae302)
@simaishi
Copy link
Contributor

simaishi commented Oct 2, 2018

Hammer backport details:

$ git log -1
commit f300d954d79a5fbcb1b64a31e234c9f6c0c8ed93
Author: Milan Zázrivec <[email protected]>
Date:   Tue Oct 2 15:19:36 2018 +0200

    Merge pull request #4711 from skateman/treeview-archorph
    
    Put background under archived/orphaned tree node icons in VMs
    
    (cherry picked from commit 5fae30201c7c2c4c6e303a164d02ba00c5339df1)

@skateman skateman deleted the treeview-archorph branch October 2, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epwinchell epwinchell epwinchell approved these changes

Assignees

@mzazrivec mzazrivec

Labels
graphics hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skateman @miq-bot @simaishi @epwinchell @mzazrivec