Encrypt replication subscription's password before queuing save operation #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot remove-label pending core |
yrudman
force-pushed
the
encrypt-replication-subscription-password-before-queuing-save-operation
branch
from
bc2ad8c to
cacc636
Compare
|
Checked commits yrudman/manageiq-ui-classic@d355243~...cacc636 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
\cc @carbonin |
yrudman
deleted the
encrypt-replication-subscription-password-before-queuing-save-operation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encrypt replication subscription's password before queuing save operation
This PR is follow-up to #4628
There is no need to change model side since encrypted password will be decrypted if needed here: https://github.com/ManageIQ/manageiq/blob/156cd6b949e5bc4837edd1d76e47e643d9250040/app/models/pglogical_subscription.rb#L242
@miq-bot add-label technical debt
https://bugzilla.redhat.com/show_bug.cgi?id=1562956