Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React textual summary for PXE images #4662

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626983

Missed in #3420

How to reproduce:

  • Go to Compute -> Infrastructure -> PXE

  • If there's no PXE server with images create some in console

PxeServer.create!(:name => 'PXE Server', :uri => "http://test.example.com/pxe_server_112211")
PxeImage.create!(:name => 'Pxe Image', :pxe_server_id => PxeServer.first.id, :description => 'Pxe Image from Hell', :kernel => 'ubuntu-10.10-desktop-i386/vmlinuz', :kernel_options => "vga=788 -- quiet")
WindowsImage.create!(:name => "Window Image", :description => "Window Image", :pxe_server_id => PxeServer.first.id)
  • click on Pxe Image and Windows Image

Before:

Error caught: [ActionView::Template::Error] Missing partial shared/summary/_textual with {:locale=>[:en], :formats=>[:js, "application/ecmascript", "application/x-ecmascript", :html, :text, :js, :css, :ics, :csv, :vcf, :png, :jpeg, :gif, :bmp, :tiff, :svg, :mpeg, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip, :gzip], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :coffee, :haml, :rjs]}. Searched in:
  * "/ManageIQ/manageiq/app/views"
  * "/ManageIQ/manageiq-ui-classic/app/views"
  * "/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/bundler/gems/manageiq-v2v-de610127be38/app/views"

/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/path_set.rb:46:in `find'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/lookup_context.rb:122:in `find'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:420:in `find_template'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:415:in `find_partial'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/partial_renderer.rb:297:in `render'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:47:in `render_partial'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/renderer/renderer.rb:21:in `render'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/actionview-5.0.7/lib/action_view/helpers/rendering_helper.rb:32:in `render'
/Users/zita/.rbenv/versions/2.4.4/lib/ruby/gems/2.4.0/gems/haml-4.0.7/lib/haml/helpers/action_view_mods.rb:12:in `render_with_haml'
ManageIQ/manageiq-ui-classic/app/views/pxe/_pxe_server_details.html.haml:63:in `___sers_zita__esktop__anage___manageiq_ui_classic_app_views_pxe__pxe_server_details_html_haml__4074327853774494466_70288532390320'

After:
screen shot 2018-09-14 at 12 56 10 pm

cc: @martinpovolny

@miq-bot add_label gaprindashvili/no, bug

@miq-bot
Copy link
Member

miq-bot commented Sep 14, 2018

Checked commit ZitaNemeckova@152619b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny self-assigned this Sep 14, 2018
@martinpovolny martinpovolny added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 14, 2018
@martinpovolny
Copy link
Member

Thank you!

@martinpovolny martinpovolny merged commit 575546a into ManageIQ:master Sep 14, 2018
@ZitaNemeckova ZitaNemeckova deleted the add_react_textual_summary_for_pxe_images branch September 14, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants