Fixed some inconsistencies on provider dashboards. #4659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
force-pushed
the
provider_dashboard_inconsistencies_fixed
branch
4 times, most recently
from
37c0a1b to
43d3255
Compare
|
This pull request is not mergeable. Please rebase and repush. |
h-kataria
force-pushed
the
provider_dashboard_inconsistencies_fixed
branch
2 times, most recently
from
66a6c42 to
aa4cd1a
Compare
h-kataria
force-pushed
the
provider_dashboard_inconsistencies_fixed
branch
from
aa4cd1a to
897f11a
Compare
skateman
reviewed
Sep 17, 2018
| @@ -163,7 +165,7 @@ def build_provider_status(provider_type) | |||
| :count => 0, | |||
| :typeName => _(provider_type.to_s), | |||
| :iconImage => provider_fileicon ? ActionController::Base.helpers.image_path(provider_fileicon) : nil, | |||
| :statusIcon => provider_status_icon | |||
| :statusIcon => provider_status_icon || nil | |||
There was a problem hiding this comment.
Is this || nil really necessary?
There was a problem hiding this comment.
@skateman removed || nil it seems to work well without that as well. I needed to set that before your recent change.
- Red crosses were added as part of ManageIQ#4453 that caused them to show up on all aggregate status cards on all provider dashboards, fixed the condition and removed setting of redundant notification hash for providers when it is not needed. - Show status icon under Alerts in aggregate card if Alerts are configured for a container provider, otherwise show "No data available" empty pf card. - On Containers Overview dashboard, Fixed to not show provider icon in Provider status aggregate card, it should only show count of providers with a link to list view to Container Providers show list. - Added a title on Container Overview dashboard screen, since that's the only screen on that subtab there are no breadcrumbs on the screen. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626199 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626427
h-kataria
force-pushed
the
provider_dashboard_inconsistencies_fixed
branch
from
897f11a to
b765b9b
Compare
|
Checked commit h-kataria@b765b9b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
@miq-bot assign @mzazrivec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626199
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1626427
before:
Container Overview
Infrastructure Provider Dashboard
Container Provider Dashboard
after:
Container Overview
Infrastructure Provider Dashboard
Container Provider Dashboard
