Do not show tooltip on listicons in GTLs when they're not clickable #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
listicon-tooltip-gtl
branch
from
287df63 to
f5d2977
Compare
skateman
force-pushed
the
listicon-tooltip-gtl
branch
from
f5d2977 to
7c89ed6
Compare
|
Checked commit skateman@7c89ed6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When displaying custom button events for a record, the listicon had a
View Detailstooltip even if the table wasn't even clickable. Through theparamsinview_to_hashit is possible to determine if it's clickable, so the tooltip can be hidden based on this boolean.@miq-bot add_label bug, gaprindashvili/no
@miq-bot add_reviewer @h-kataria
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1628245