Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make chart loading more error resistant. #465

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

martinpovolny
Copy link
Member

With recent removal of jqplot stuff you can get:

/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/visitor.rb:15:in `visit'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/visitor.rb:5:in `accept'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/to_ruby.rb:31:in `accept'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/to_ruby.rb:310:in `visit_Psych_Nodes_Document'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/visitor.rb:15:in `visit'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/visitor.rb:5:in `accept'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/visitors/to_ruby.rb:31:in `accept'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych/nodes/node.rb:37:in `to_ruby'
/home/martin/.rvm/gems/ruby-2.3.3/gems/psych-2.0.17/lib/psych.rb:252:in `load'
/home/martin/Projects/manageiq-ui-classic/lib/charting/c3_charting.rb:35:in `data_ok?'
/home/martin/Projects/manageiq-ui-classic/app/views/dashboard/_widget_chart.html.haml:12:in `__home_martin__rojects_manageiq_ui_classic_app_views_dashboard__widget_chart_html_haml___2628784257344300695_23625540'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/template.rb:159:in `block in render'
/home/martin/.rvm/gems/ruby-2.3.3/gems/activesupport-5.0.1/lib/active_support/notifications.rb:166:in `instrument'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/template.rb:354:in `instrument'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/template.rb:157:in `render'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/renderer/partial_renderer.rb:343:in `render_partial'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/renderer/partial_renderer.rb:311:in `block in render'
/home/martin/.rvm/gems/ruby-2.3.3/gems/actionview-5.0.1/lib/action_view/renderer/abstract_renderer.rb:42:in `block in instrument'
/home/martin/.rvm/gems/ruby-2.3.3/gems/activesupport-5.0.1/lib/active_support/notifications.rb:164:in `block in instrument'
/home/martin/.rvm/gems/ruby-2.3.3/gems/activesupport-5.0.1/lib/active_support/notifications/instrumenter.rb:21:in `instrument'
/home/martin/.rvm/gems/ruby-2.3.3/gems/activesupport-5.0.1/lib/active_support/notifications.rb:164:in `instrument'

This fixes the problem.

@martinpovolny
Copy link
Member Author

ping @mzazrivec, @skateman

@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2017

Checked commit martinpovolny@e29e693 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🏆

Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mzazrivec mzazrivec self-assigned this Feb 24, 2017
@mzazrivec mzazrivec added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 24, 2017
@mzazrivec mzazrivec merged commit 886943e into ManageIQ:master Feb 24, 2017
@martinpovolny martinpovolny deleted the chart_load_fix branch March 8, 2017 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants