Allow restoring backups to new volumes

[mansam]

Allows choosing to restore a volume backup to a newly created volume, and adds a field for optionally naming that volume.

Partially implements https://bugzilla.redhat.com/show_bug.cgi?id=1514970
Depends on core and openstack provider PRs, as well as a new fog-openstack release.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

Checked commit mansam@e250f6e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

[mansam]

Depends on ManageIQ/manageiq#17952

[martinpovolny]

Hammer?

[mansam]

@martinpovolny No, this doesn't need to be backported to hammer.

[mansam]

@martinpovolny Do you know who might have time to review this?

[mansam]

Ping @martinpovolny, could you assign this to someone for review when you have the chance? It's the last piece of an RFE and the other pieces have long since been merged.

[ZitaNemeckova]

No, this doesn't need to be backported to hammer.

@miq-bot add_label hammer/no

@ManSan I'm not sure about few backend things. Below is a form for a new Volume (please correct me if it isn't the correct one) and few things seems to be missing for a new Volume like a Cloud Tenant and Size in your form. Shouldn't Name be required?

If Name is optional for a new Cloud in your form and Cloud Tenant and Size aren't needed then it is good :)

[mansam]

Hi @ZitaNemeckova, thanks for the review! Volume name is optional when restoring Openstack backups, size is unnecessary, and Cloud Tenant is automatically determined by the backend based on the backup being restored.

[ZitaNemeckova]

@mansam thanks for explaining :)

LGTM 👍

[himdel]

Restarting travis, just to make sure nothing got broken since November, will merge when green :)

[himdel]

@mansam something did..

  1) AuthKeyPairCloudController#report_data when tile mode is selected returns key pairs with quadicons
     Failure/Error: expect(results['data']['rows'][0]['quad']).to have_key('fonticon')
       expected  to respond to `has_key?`
     # ./spec/controllers/auth_key_pair_cloud_controller_spec.rb:98

looks like quad is nil now.

[himdel]

Caused by
ff6d639, #3789 - removed CloudManager::AuthKeyPair decorator because the parent AuthPrivateKey was identical
together with
ManageIQ/manageiq@321d9d386fb, ManageIQ/manageiq#18633 - changed the parent of CloudManager::AuthKeyPair from AuthPrivateKey to Authentication.

So, looks like you'll need a https://github.com/ManageIQ/manageiq-decorators PR to add a decorator for Authentication or CloudManager::AuthKeyPair.

(cc @skateman)

[himdel]

Eeeh... never mind @mansam ..

I'm looking for a cause in this PR, finding none, but our master is red.

So... you don't have to do anything, we do :).

And merging, because except for the one failure shared with master, travis is indeed green.

[himdel]

=> ManageIQ/manageiq-decorators#4

[mansam]

@himdel @ZitaNemeckova thanks!