Update open_nodes when creating new element #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @romanblanco |
|
@miq-bot assign @romanblanco |
romanblanco
reviewed
Sep 4, 2018
| @@ -2729,6 +2733,11 @@ def flash_validation_errors(am_obj) | |||
| end | |||
| end | |||
|
|
|||
| def add_active_node_to_open_nodes | |||
| return unless @sb.dig('trees') && @sb.dig('trees').dig('ae_tree') && @sb.dig('trees').dig('ae_tree').dig('open_nodes') | |||
There was a problem hiding this comment.
@PanSpagetka by using #dig, you don't need to investigate each node separately
return unless @sb.dig('trees', 'ae_tree', 'open_nodes').present?
romanblanco
suggested changes
Sep 4, 2018
PanSpagetka
force-pushed
the
bz-1611969
branch
from
aaa88d6 to
15a54df
Compare
|
@miq-bot add_label bug, automate |
|
@romanblanco Cannot apply the following label because they are not recognized: automate |
|
Checked commits PanSpagetka/manageiq-ui-classic@a452ea1~...15a54df with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label automation/automate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was caused by not properly setting environment for treebuilder, resulting in treebulder not build only shallow version of the tree and focused element was not included in rendered tree, so it couldn't be selected.
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1611969
Steps for Testing/QA [Optional]