VmOrTemplateDecorator - remove supports_console and supports_cockpit #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only used by the API, for the Vms collection, removed in ManageIQ/manageiq#14040
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/3e4f447f248ad335e9479f4aa247ebf40ea8fe63 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I'm confused how this is UI only. I would expect the UI to ask, not assume, and so would ask through an OPTIONS call to the API. |
|
OHHHH nevermind, I thought you were removing from the vm_or_template itself. I didn't realize these were simple wrappers around provider level support_* methods. |
|
Yeah, I'm just trying to move this logic to the model, where it belongs. |
|
Removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: ManageIQ/manageiq#14040
only used by the API, for the Vms collection, removed in ManageIQ/manageiq#14040.
(Related to #237.)