Show CloudTenants in network manager's topology view #4569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit we let NetworkManager's topology view render CloudTenants with basic entities beneath them in order for Nuage provider to display a meaningful topology view. Since Nuage provider subclasses CloudSubnets into ``` ManageIQ::Providers::Nuage::NetworkManager::CloudSubnet::L2 ManageIQ::Providers::Nuage::NetworkManager::CloudSubnet::L3 ``` we also make sure those get appropriate class name assigned (i.e. base class name). Signed-off-by: Miha Pleško <[email protected]>
|
Checked commit miha-plesko@34672dc with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/services/network_topology_service.rb
|
|
😂 @skateman this seal of yours, I cant get enough of it, I laugh every time, best joke ever 😂 |
|
Made by @mzazrivec actually 😉 |
|
We all love @skateman's seal of approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we let NetworkManager's topology view render CloudTenants with basic entities beneath them in order for Nuage provider to display a meaningful topology view.
Since Nuage provider subclasses CloudSubnets into
we also make sure those get appropriate class name assigned (i.e. base class name) or else nothing is shown.
Before
Amazon provider:
Nuage provider:
After:
Amazon provider (proof that nothing has changed):
Nuage provider:
Fixes #4316
@miq-bot add_label enhancement
@miq-bot assign @himdel