Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Chassis to PhysicalInfra dashboard and listnav #4567

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Add Chassis to PhysicalInfra dashboard and listnav #4567

merged 1 commit into from
Sep 4, 2018

Conversation

felipedf
Copy link
Member

@felipedf felipedf commented Aug 29, 2018 •
edited
Loading

This PR is able to:

  • Add a chassis to PhysicalInfra provider dashboard
  • Add both chassis and rack to PhysicalInfra provider listnav

screenshot-localhost-3000-2018 08 29-13-51-41

screenshot-localhost-3000-2018 08 29-13-54-58

@felipedf felipedf changed the title Adding chassis to physical infra dashboard and adding racks and chass… Add Chassis to PhysicalInfra dashboard and listnav Aug 29, 2018
mzazrivec
mzazrivec reviewed Aug 30, 2018
View reviewed changes
app/services/ems_physical_infra_dashboard_service.rb Outdated

attr_icon = {
:physical_chassis => 'pficon pficon-cluster',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@epwinchell Is this the correct icon for chassis?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terezanovotna Any suggestions for chassis?

@terezanovotna
Copy link

  1. in the relationship listnav, can we alphabetize the items?
  2. reached out to UXD team about chassis icon, should be back with details soon!

@terezanovotna
Copy link

How about pficon-template?
screen shot 2018-08-30 at 19 26 41

Any other suggestions? Feel free to check out Font Awesome

@felipedf
Copy link
Member Author

felipedf commented Aug 30, 2018 •
edited
Loading

in the relationship listnav, can we alphabetize the items?

Tried to somehow be consistent with the relationship table on the summary, even though they are already different, what about alphabetize both?

How about pficon-template?

I like that

@terezanovotna

@terezanovotna
Copy link

Tried to somehow be consistent with the relationship table on the summary, even though they are already different, what about alphabetize both?

Good idea!

@felipedf felipedf force-pushed the add_chassis_dashboard branch 3 times, most recently from c4a8482 to c14d857 Compare August 30, 2018 19:14
@miq-bot
Copy link
Member

miq-bot commented Aug 31, 2018

This pull request is not mergeable. Please rebase and repush.

@felipedf felipedf force-pushed the add_chassis_dashboard branch from c14d857 to e6e685e Compare August 31, 2018 12:28
@miq-bot
Copy link
Member

miq-bot commented Aug 31, 2018

Checked commit felipedf@e6e685e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 👍

@felipedf
Copy link
Member Author

felipedf commented Sep 3, 2018

Updated SS
screenshot-localhost-3000-2018 09 03-11-06-32
screenshot-localhost-3000-2018 09 03-11-07-23

@terezanovotna
Copy link

Thanks for doing the changes @felipedf! It looks great!

@miq-bot add_label ux/approved

@mzazrivec mzazrivec self-assigned this Sep 4, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sep 10, 2018 milestone Sep 4, 2018
@mzazrivec mzazrivec merged commit 182fd89 into ManageIQ:master Sep 4, 2018
@felipedf felipedf deleted the add_chassis_dashboard branch September 4, 2018 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzazrivec mzazrivec mzazrivec left review comments

@epwinchell epwinchell epwinchell left review comments

Assignees

@mzazrivec mzazrivec

Labels
compute/physical infrastructure enhancement ux/approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felipedf @terezanovotna @miq-bot @epwinchell @mzazrivec