Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use device_name for cdrom reconfiguration request #4548

Merged
merged 2 commits into from
Aug 29, 2018

Conversation

lgalis
Copy link
Contributor

@lgalis lgalis commented Aug 27, 2018

Use device_name for cdrom reconfiguration request.
Remove duplicate of updateCDRomsConnectDisconnect.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1533728
Follow up for #3956

@miq-bot miq-bot added the wip label Aug 27, 2018
@lgalis lgalis force-pushed the use_device_name_for_cdrom branch 11 times, most recently from fc457e1 to d5440f7 Compare August 28, 2018 12:14
@lgalis lgalis force-pushed the use_device_name_for_cdrom branch from d5440f7 to 923ed31 Compare August 28, 2018 15:12
@lgalis lgalis changed the title [WIP]Use device_name for cdrom reconfiguration request Use device_name for cdrom reconfiguration request Aug 28, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Aug 28, 2018

@h-kataria - please review

@miq-bot miq-bot removed the wip label Aug 28, 2018
@lgalis
Copy link
Contributor Author

lgalis commented Aug 28, 2018

@miq-bot add_label bug, gaprindashvili/no

@miq-bot
Copy link
Member

miq-bot commented Aug 29, 2018

Checked commits lgalis/manageiq-ui-classic@923ed31~...3475a1c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@h-kataria h-kataria self-assigned this Aug 29, 2018
@h-kataria h-kataria added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 29, 2018
@h-kataria h-kataria merged commit 40fdf8c into ManageIQ:master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants