Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the webkit scrollbars are applied to About modal only #4546

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

AparnaKarve
Copy link
Contributor

Fixes #4541

/cc @epwinchell

@miq-bot miq-bot added the wip label Aug 27, 2018
@miq-bot
Copy link
Member

miq-bot commented Aug 27, 2018

Checked commit AparnaKarve@e379a5b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@epwinchell
Copy link
Contributor

epwinchell commented Aug 27, 2018

@Hyperkid123 Please test. I will clean up the css when I'm able to do a styling PR for the modal.

Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Menu and page scrollbars are fixed.

@epwinchell
Copy link
Contributor

@miq-bot add_reviewer @epwinchell

@epwinchell
Copy link
Contributor

@miq-bot rm_label wip

@miq-bot miq-bot requested a review from epwinchell August 28, 2018 13:32
@miq-bot miq-bot changed the title [WIP] Ensure that the webkit scrollbars are applied to About modal only Ensure that the webkit scrollbars are applied to About modal only Aug 28, 2018
@miq-bot miq-bot removed the wip label Aug 28, 2018
@mzazrivec mzazrivec self-assigned this Aug 29, 2018
@mzazrivec mzazrivec added this to the Sprint 94 Ending Sept 10, 2018 milestone Aug 29, 2018
@mzazrivec mzazrivec merged commit 69f4f9b into ManageIQ:master Aug 29, 2018
@AparnaKarve AparnaKarve deleted the fix_scrollbar_in_main_ui branch August 29, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants