Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1615826
What:
There is a bug in Datastores screen: previous basic search is not erased for last selected filter (node in the tree) before applying another basic search. This happens because basic search text is saved for each node in the tree, not for actual explorer screen.
Details:
Code should remember search text/string per explorer, not for each node/filter selected in the tree. I tried the same steps to reproduce in other explorer screens and I was not able to reproduce the behavior. It seems to be working correctly in other screens, search string is only being remembered per explorer. The behavior implemented in Datastores screen is a bug. The right search string is always set by calling
process_show_list
method here https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/storage_controller/storage_d.rb#L27 or https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/storage_controller/storage_d.rb#L41, no need to implement anything else.Note:
The fix in this PR works also in the Datastore screen displayed through other screens (provider's details page) and also if going away to some totally different screen and going back to Datastores screen.
Steps to reproduce:
=> basic search changed to the previous one!!!
Step 3 from steps to reproduce (Provisioning Scope/All global filter - the 1st applied one):
Step 4 from steps to reproduce (Store Type/FCP global filter - the 2nd applied one):
Before: (clicking on the filter applied as the 1st one)
After: