Enable 'Paste' button if the coppied data are in the session #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit romanblanco@4dfc0ac with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
h-kataria
reviewed
Aug 28, 2018
| @@ -1,6 +1,6 @@ | |||
| #ab_form | |||
| #policy_bar | |||
| - if @resolve[:uri] && Hash[*@resolve[:target_classes].flatten].invert[@resolve[:new][:target_class]] == @edit[:new][:target_class] | |||
| - if session[:resolve_object].present? | |||
There was a problem hiding this comment.
@romanblanco this button should only be available when same target class is selected in the tree as in the options that were copied over, you are missing the condition from the check that was removed in this PR Hash[*@resolve[:target_classes].flatten].invert[@resolve[:new][:target_class]] == @edit[:new][:target_class]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1426390
Closes: #4189
I didn't much understood the original condition used to decide button's state, but I didn't yet found another button, which functionality I could break by the change.
The
@resolve[:uri]is only possibly getting filled, if theparams[:button]is"throw"or"retry":https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller/automate.rb#L155
The condition now tests for the data presence in the session (data are assigned to the session in https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/application_controller/automate.rb#L40-L44)
Links
Steps for Testing/QA