Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip protect_from_forgery for #authenticate #451

Merged
merged 1 commit into from
Feb 22, 2017
Merged

Skip protect_from_forgery for #authenticate #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class ApplicationController < ActionController::Base
# This secret is reset to a value found in the miq_databases table in
# MiqWebServerWorkerMixin.configure_secret_token for rails server, UI, and
# web service worker processes.
protect_from_forgery :secret => SecureRandom.hex(64), :except => :csp_report, :with => :exception
protect_from_forgery :secret => SecureRandom.hex(64), :except => [:authenticate, :csp_report], :with => :exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jvlcek if this is related to the ext-auth issue you were troubleshooting, we might need to add exceptions for the other two methods in dashboard_controller, namely :external_authenticate (for ext-auth), and :kerberos_authenticate (SSO). Thanks.

Copy link
Member

@abellotti abellotti Mar 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @jvlcek we should be ok with SAML, but probably need to test that too. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abellotti : what about :saml_login, :initiate_saml_login ?

end

helper ChartingHelper
Expand Down
1 change: 0 additions & 1 deletion app/views/layouts/login.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
= javascript_include_tag 'miq_debug'
= stylesheet_link_tag 'miq_debug'

= csrf_meta_tag
= render :partial => 'layouts/i18n_js'

%body{:class => ::Settings.server.custom_login_logo ? 'whitelabel' : ''}
Expand Down