Respect days parameter when listing timeline events

[tadeboro]

Up until now, when the user requested hourly report (by selecting days selector in the UI), the code always returned only the events from the last day of selected interval.

This commit fixes this by unifying the time interval construction for all types of reports, getting rid of the buggy date construction in the process.

Fixes #4503

[miq-bot]

Checked commit xlab-si@94c9796 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

[tadeboro]

@miq-bot add_reviewer @skateman

[mzazrivec]

@PanSpagetka Could you please look at the above change? Thanks.

[skateman]

@miq-bot add_reviewer @PanSpagetka

[PanSpagetka]

I know, that there are some issues in this area, but wasn't able to reproduce them. But I test it in UI and your code works and looks nicer.

[tadeboro]

@PanSpagetka To reproduce the issue, make sure "days" is active when selecting interval and select more than one day.

The actual code that is broken:

manageiq-ui-classic/app/controllers/application_controller/timelines.rb

Lines 85 to 86 in 019baf1

	from_dt = create_time_in_utc("#{yy}-#{mm}-#{dd} 00:00:00", session[:user_tz]) # Get tz 12am in user's time zone
	to_dt = create_time_in_utc("#{yy}-#{mm}-#{dd} 23:59:59", session[:user_tz]) # Get tz 11pm in user's time zone

As can be seen above, single-day interval is hard-coded into start and end date construction.

[tadeboro]

Screenshots of parameter selection are available in the bug #4504 (last two screenshots).

[skateman]

@PanSpagetka I verified that after the change the query is generated properly for the whole interval and not just for a single day.

[PanSpagetka]

Yeah, now I have reproduced it, good job @tadeboro

@mzazrivec LGTM