Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Worflow Templates do not have job_plays and raw_stdout_via_worker #4486

Merged

Conversation

h-kataria
Copy link
Contributor

Added a check in code to not try to show "Plays" section and load standard output for workflow template type services.

Fixes #4444

Ansible Playbook Service details
ansible_playbook_service

Workflow Template Service details
workflow_template_service

@lfu please review/test

Added a check in code to not try to show "Plays" section and load standard output for workflow template type services.

Fixes ManageIQ#4444
@miq-bot
Copy link
Member

miq-bot commented Aug 16, 2018

Checked commit h-kataria@2930b59 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@dclarizio dclarizio merged commit 357df7a into ManageIQ:master Aug 16, 2018
@dclarizio dclarizio added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 16, 2018
@h-kataria h-kataria deleted the fixes_workflow_template_summary_screen branch October 24, 2018 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants