Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing 'public_service_templates' scope #4473

Conversation

h-kataria
Copy link
Contributor

@h-kataria h-kataria commented Aug 14, 2018

Added 'public_service_templates' scope when fetching right side list for unassigned folder node

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408

before:
before

after:
after

@hsong-rh @bzwei please review

Added 'public_service_templates' scope when fetching right side list for unassigned folder node

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1594408
@h-kataria h-kataria force-pushed the exclude_migration_template_unassigned_folder branch from 5acc2f9 to 5362d75 Compare August 14, 2018 16:00
@miq-bot
Copy link
Member

miq-bot commented Aug 14, 2018

Checked commit h-kataria@5362d75 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio dclarizio merged commit 0b219e9 into ManageIQ:master Aug 14, 2018
@dclarizio dclarizio added this to the Sprint 93 Ending Aug 27, 2018 milestone Aug 14, 2018
simaishi pushed a commit that referenced this pull request Aug 14, 2018
…assigned_folder

Added missing 'public_service_templates' scope
(cherry picked from commit 0b219e9)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 23574ded21541a4628e7aa05e0b8b8970f8b2fbd
Author: Dan Clarizio <[email protected]>
Date:   Tue Aug 14 09:36:20 2018 -0700

    Merge pull request #4473 from h-kataria/exclude_migration_template_unassigned_folder
    
    Added missing 'public_service_templates' scope
    (cherry picked from commit 0b219e9248c8814caf0ed25831cbf69e41a2fcf7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1610729

@h-kataria h-kataria deleted the exclude_migration_template_unassigned_folder branch October 24, 2018 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants