Fix to render pagination and listnav on list view. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-kataria
changed the title
h-kataria
force-pushed
the
ems_infra_list_view_fix
branch
from
b832b05 to
f5c6b5c
Compare
h-kataria
changed the title
Fixed a condition to make sure listnav & paginator are rendered on list view. https://bugzilla.redhat.com/show_bug.cgi?id=1422449
h-kataria
force-pushed
the
ems_infra_list_view_fix
branch
from
f5c6b5c to
d7bbf91
Compare
|
Checked commit h-kataria@d7bbf91 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a condition to make sure listnav & paginator are rendered on list view.
https://bugzilla.redhat.com/show_bug.cgi?id=1422449
to recreate to Infrastructure Provider list view, then go to a PRovider summary screen, switch view to Dashboard view of selected provider then using breadcrumb link go back to List of providers. Paginator, Title & listnav are missing. This PR fixes to render paginator & listnav on list view.
before
after
@dclarizio please review.