Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the health_state quadicon #4348

Merged
merged 1 commit into from
Jul 25, 2018
Merged

Fix the health_state quadicon #4348

merged 1 commit into from
Jul 25, 2018

Conversation

CharlleDaniel
Copy link
Member

@CharlleDaniel CharlleDaniel commented Jul 24, 2018 •
edited
Loading

This PR is able to:

  • Fix the health state quadicon not shown the warning icon and unknown icon when a resource have one these states

switch_page

@CharlleDaniel
Fix the health state quadicon not shown the warining icon and unknown…
be1e2e9 
… icon when a resource have one these heath states
@CharlleDaniel
Copy link
Member Author

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jul 24, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2018

Checked commit https://github.com/CharlleDaniel/manageiq-ui-classic/commit/be1e2e9c4fde7e1b01aa6c785938a5e72b8ff2bd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec mzazrivec requested a review from skateman July 25, 2018 09:37
skateman
skateman approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval

@martinpovolny martinpovolny merged commit 0f8329d into ManageIQ:master Jul 25, 2018
@martinpovolny martinpovolny added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 25, 2018
@martinpovolny martinpovolny self-assigned this Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@martinpovolny martinpovolny

Labels
bug compute/physical infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CharlleDaniel @miq-bot @skateman @martinpovolny @mzazrivec