Remove VM Transform buttons

[smelamud]

Remove 'Transform tagged VMs to RHV' and 'Transform this VM to RHV' from
the toolbar.

Partially fixes https://bugzilla.redhat.com/show_bug.cgi?id=1585452

[smelamud]

@miq-bot assign mwperina

[miq-bot]

@smelamud 'mwperina' is an invalid assignee, ignoring...

[smelamud]

@miq-bot assign himdel

[smelamud]

@miq-bot assign martinpovolny

[miq-bot]

Checked commit smelamud@d399002 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 👍

[himdel]

@smelamud Looks like this does not even try to remove any old v2v code, and does therefore not fix the BZ in question ;).

All of these still look related:

spec/controllers/vm_infra_controller_spec.rb
407:    let(:dialog)           { FactoryGirl.create(:dialog, :label => 'Transform VM', :buttons => 'submit') }
410:    it 'can Transform selected VM' do

spec/controllers/catalog_controller_spec.rb
1116:        let(:dialog) { FactoryGirl.create(:dialog, :label => 'Transform VM', :buttons => 'submit') }

app/controllers/application_controller/ci_processing.rb
21:    include Mixins::Actions::VmActions::Transform
27:    include Mixins::Actions::ProviderActions::MassTransform

app/controllers/mixins/actions/vm_actions/transform.rb
4:      module Transform
6:          dialog = Dialog.find_by(:label => 'Transform VM')
8:          @right_cell_text = _("Transform VM %{name} to RHV") % {:name => vm.name}

app/controllers/mixins/actions/provider_actions/mass_transform.rb
4:      module MassTransform
6:          dialog = Dialog.find_by!(:label => 'Transform VM')
7:          @right_cell_text = _("Transform VMs to RHV")

app/helpers/application_helper/button/mass_transform_vm_button.rb
1:class ApplicationHelper::Button::MassTransformVmButton < ApplicationHelper::Button::Basic

app/helpers/application_helper/button/transform_vm_button.rb
1:class ApplicationHelper::Button::TransformVmButton < ApplicationHelper::Button::Basic

[smelamud]

@himdel Yes, it wasn't intended to remove all the code. It is only hiding the buttons, that is needed ASAP. The removal of the code will be done with another PR.

[JPrause]

@miq-bot add_label blocker

[JPrause]

@smelamud if this can be backported, can you add the gaprindashvili/yes label

[smelamud]

@miq-bot add_labels gaprindashvili/yes

[smelamud]

@miq-bot assign himdel

[himdel]

As long as the other PR is coming, I have no problem with this :)

Just please remember the second PR @smelamud.

[mwperina]

This is PR is intended to be backported to 5.9.z, where we don't want to introduce massive code changes.

The following PR, which actually removes old v2v code, will be targeted only to 5.10, because we will have much more time to fix potential issues caused by this code removal

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit b9d0731f07852b3bdf7c8c50861c4296358e3d22
Author: Martin Hradil <[email protected]>
Date:   Wed Jul 25 15:20:07 2018 +0100

    Merge pull request #4336 from smelamud/vm-transform-button-remove
    
    Remove VM Transform buttons
    (cherry picked from commit 198c28c78f794c8e9a7bb15aca0d0982b04ecc55)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1608581