Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in textual_region #4317

Merged
merged 1 commit into from
Jul 19, 2018

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Jul 19, 2018

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1602095

Steps to Reproduce:
1.) Configure an appliance in region 0 as a remote appliance and an appliance in region 99 as the global appliance.
2.) Add an infrastructure provider to the remote appliance.
3.) View one of the provider's VM's in the global appliance's web UI.

Or a little hack in code:

--- a/app/helpers/textual_mixins/textual_region.rb
+++ b/app/helpers/textual_mixins/textual_region.rb
 module TextualMixins::TextualRegion
   def textual_region
-    return nil if @record.region_number == MiqRegion.my_region_number
+    #return nil if @record.region_number == MiqRegion.my_region_number
     h = {:label => _("Region")}
     reg = @record.miq_region
-    url = reg.remote_ui_url
+    url = "reg.remote_ui_url"

Click at Region and new window should open.

Before:
screen shot 2018-07-19 at 11 28 34 am

After:
screen shot 2018-07-19 at 11 27 16 am

@miq-bot add_label gaprindashvili/no, bug, blocker, wip

"return miqClickAndPop(this);" replaced by :external => true

@miq-bot miq-bot changed the title Fix link in textual_region [WIP] Fix link in textual_region Jul 19, 2018
@ZitaNemeckova
Copy link
Contributor Author

@miq-bot remove_label wip

@h-kataria please review, thanks :)

@miq-bot miq-bot changed the title [WIP] Fix link in textual_region Fix link in textual_region Jul 19, 2018
@miq-bot miq-bot removed the wip label Jul 19, 2018
@miq-bot
Copy link
Member

miq-bot commented Jul 19, 2018

Checked commit ZitaNemeckova@58718bb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

@h-kataria h-kataria self-assigned this Jul 19, 2018
@h-kataria h-kataria added this to the Sprint 91 Ending Jul 30, 2018 milestone Jul 19, 2018
@h-kataria h-kataria merged commit 0f2d503 into ManageIQ:master Jul 19, 2018
@ZitaNemeckova ZitaNemeckova deleted the fix_textual_region branch July 20, 2018 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants