Allow to save multiple tag categories in chargeback controller

[lpichler]

Behaviour:

Before:
It was possible to save just assignment for Tagged VMs and Instances only for ONE Tag Category

After:
It is possible to save it also for multiple categories:

Implementation details

@edit[:cb_assign][:tags] as you can see in
code(@edit[:cb_assign][cb_assign_key]) is bringing
selected chargeback rates for tags in selected tag category which is
stored in @edit[:new][:cbtag_cat]

to keep selected chargeback rates for any count of tag categories
we need to extend @edit[:cb_assign][:tags] to
@edit[:cb_assign][:tags] [category_id] and this hash can
keep multiple chargeback rates across any count of
tag categories.

we need to update code when chargeback rate is
selected ( in method cb_assign_params_to_edit called by
controller action cb_assign_field_changed) and then
when we want to save this selection of chargeback rates
in cb_assign_update.

Note
This PR will need probably also some work to make it better from UX aspects but leave it on other PR.
This PR accomplish it from functional aspects.

Links

https://bugzilla.redhat.com/show_bug.cgi?id=1581349
https://bugzilla.redhat.com/show_bug.cgi?id=1601228

[miq-bot]

Checked commit lpichler@5b77319 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[lpichler]

@miq-bot add_label gaprindashvili/yes, blocker

cc @gtanzillo

please review @hstastna

@miq-bot assign @mzazrivec

[hstastna]

@miq-bot add_reviewer @hstastna

[hstastna]

For me the change is not obvious from the screenshot, and I am missing any steps how to test this properly. I'm not sure how these Assignments work. How can I check if multiple tag categories were properly set? Tried to test it but I still see only the one last selected tag category there. Maybe I am missing something. Thank you.

[hstastna]

Ahh, I was missing the next steps how to test it:

1. Cloud Intel > Chargeback > Assignments > Compute
2. Set Assign To as Tagged... from the dropdown
3. Then set Tag Category, too
4. Set some Selections from the dropdowns
5. Save the assignment
6. Repeat the steps 3 - 5 and save again
7. Change the Tag Category to the previous one you've set
   => you can see the same selections as you've previously set, not just <Nothing>

@lpichler Please, correct me if I am wrong. Thanks. 🎇

[hstastna]

The weird thing is that if I try to set the assignment and to save it more times in a row, right after saving it, the previous assignment appears in the screen, not the last one. I mean, different Category and Selections appear in the screen, not the latest saved ones. For me this behavior does not make sense.

[lpichler]

@hstastna thanks for the review and comments, yes UX is weird but from functional point of view (saving multiple rates across various category) it is OK. So I am suggesting to do such UX in follow up PR.

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 4bcb15607377b17d3810f6fff120b92a254061c7
Author: Milan Zázrivec <[email protected]>
Date:   Fri Aug 3 15:14:09 2018 +0200

    Merge pull request #4310 from lpichler/save_multiple_tag_categories_in_chargeback_assignments
    
    Allow to save multiple tag categories in chargeback controller
    (cherry picked from commit a296004924bb35d0403b297f5c64b8f341aa5971)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1612889