Configure app to work with react HashRouter #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperkid123
force-pushed
the
router-debug
branch
from
d795715 to
08e3ee9
Compare
|
Checked commits Hyperkid123/manageiq-ui-classic@aa14e54~...08e3ee9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
karelhala
approved these changes
Jul 12, 2018
|
Looks like GTLs and toolbars are still behaving correctly, LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular
$locationProvideris listening on URL fragment change and with default settings it enfoces!as a hash prefix. This was causing conflict with react-router when its usinghashHistory. Both are trying to add their own prefix (angular !#, react #) and that was causing infinite loop.By removing angular default prefix, this conflict was resolved. Note that react
hashHistory(repo: https://github.com/ReactTraining/history) can be configured with hashbang prefix and we can add it if need be, but both $locationProvider and ReactRouter must have the same prefix in order to work alongside each other.because we are currently not using any angular client-side routing, no existing angular components should be affected.