webpack:paths - always load inflectors

[himdel]

this was working when run as part of webpack:compile
but running webpack:paths by itself would fail to generate config/webpack/paths.json with manageiq-v2v, using manageiq-v2_v instead

@NickLaMuro please review :)

[NickLaMuro]

Just a small suggestion. I was using invoke in the above since we had to do the Dir.chdir nonsense, but I think it makes more sense for this case to just do prereqs.

The alternative suggestion is just a convenience method, and not required.

[NickLaMuro]

I think we should just make this a prerequisite of the task using the normal mechanisms:

task :paths => ["ui:load_app_inflectors", "ui:load_asset_engine_inflectors"] do

---

Alternatively, we could also make a task under the :ui namespace that does this:

task :load_inflectors => ["ui:load_app_inflectors", "ui:load_asset_engine_inflectors"]

And then the above turns into:

task :paths => "ui:load_inflectors" do

[NickLaMuro]

@himdel sorry about not doing this right the first time around. Thanks for the fix!

[himdel]

No problem, fixed, thanks :)

[miq-bot]

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/d0e5b1ffdd9793c39c918ff432d424e993b67aca with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[NickLaMuro]

Cool. Looks good (though I am now officially saying this about my own code effectively...).

[Fryguy]

Merged, but as I'm thinking about the inflectors code, I'm thinking Vmdb::Inflections.load_inflections should handle engines directly, and then you don't need 2 tasks.

[NickLaMuro]

@Fryguy sure. My original intent of this was to make this an isolated without needing anything from the main repo for ease of initial merge. As this becomes less of a "one off", I am completely fine with this being something that is given more thought and first class support in our plugins.

But again, Sir Hacky McHackHack (aka, me), signing off on this one for now.