Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Automate import domain from git repository to use current user. #4170

Merged
merged 1 commit into from
Jun 20, 2018
Merged

Fixed Automate import domain from git repository to use current user. #4170

merged 1 commit into from
Jun 20, 2018

Conversation

billfitzgerald0120
Copy link
Contributor

@billfitzgerald0120 billfitzgerald0120 commented Jun 19, 2018 •
edited
Loading

Changed import from git repository from system to current user.
Updated test.

This will make the git repository import consistent with other imports.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591809

@billfitzgerald0120
Fixed Automate import domain from git repository to use current user.
85dccf4 
Changed import from git repository from system to current user.
Updated test.
@billfitzgerald0120
Copy link
Contributor Author

@miq-bot add_label automation/automate, bug

@miq-bot
Copy link
Member

miq-bot commented Jun 19, 2018

Checked commit billfitzgerald0120@85dccf4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@mzazrivec
Copy link
Contributor

@mkanoor Review please? Thank you.

@billfitzgerald0120
Copy link
Contributor Author

@h-kataria @dclarizio Can you review this ? Thanks

@h-kataria h-kataria self-assigned this Jun 20, 2018
@h-kataria h-kataria added this to the Sprint 89 Ending Jul 2, 2018 milestone Jun 20, 2018
@h-kataria h-kataria merged commit 2bda712 into ManageIQ:master Jun 20, 2018
@JPrause
Copy link
Member

JPrause commented Jun 21, 2018

@miq-bot add_label blocker

simaishi pushed a commit that referenced this pull request Jul 11, 2018
@h-kataria @simaishi
Merge pull request #4170 from billfitzgerald0120/git_based_domain_import
deaa804 
Fixed Automate import domain from git repository to use current user.
(cherry picked from commit 2bda712)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1595416
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit deaa804f8e6dc67c917269621571acd3887937a2
Author: Harpreet Kataria <[email protected]>
Date:   Wed Jun 20 13:46:37 2018 -0400

    Merge pull request #4170 from billfitzgerald0120/git_based_domain_import
    
    Fixed Automate import domain from git repository to use current user.
    (cherry picked from commit 2bda712fefb57659a8ce86413067fb36e4018e92)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1595416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkanoor mkanoor mkanoor approved these changes

Assignees

@h-kataria h-kataria

Labels
automation/automate blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@billfitzgerald0120 @miq-bot @mzazrivec @JPrause @simaishi @mkanoor @h-kataria