Fixing showtype error #4164
Merged
Fixing showtype error #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commit douglasgabriel@55511b9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@miq-bot add_label bug |
|
This one is hard to review properly, I have read through a bunch of places, seems to me this is a correct fix. In other places (such as ems_infra) we set the value too. |
|
Also fixes https://bugzilla.redhat.com/show_bug.cgi?id=1542907, adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to
Steps to Reproduce
show_listpage of physical providers;listnavis not shown:This issue is due to
@showtypevalue that remains as"dashboad"which removes thelistnavaccording to the logic insideapp/helpers/application_helper/page_layouts.rb#layout_uses_listnav?