Use decorators for icons/images in the compressed compare view #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
commented
Jun 15, 2018
| html_text << | ||
| "<a href=\"/ems_cluster/show/#{h[:id]}\"> | ||
| <img src=\"#{img}\" align=\"middle\" border=\"0\" width=\"20\" height=\"20\"/> | ||
| <i class=\"#{icon}\" align=\"middle\" border=\"0\" width=\"20\" height=\"20\"/> |
There was a problem hiding this comment.
@epwinchell I'm not sure if this looks good or not, the fonticon is blue as the link's text (see screenshot)
|
Checked commit skateman@1830391 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We removed the PNG images that are still being used for comparing clusters. To fix this we should display the fonticon for them, and it's more safe to do so with decorators, for all cases.
Before:
After:
@miq-bot add_label bug, gaprindashvili/no, graphics
@miq-bot add_reviewer @epwinchell