Use the client-side printing for reports where the PDF was generated synchronously #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skateman Cannot apply the following label because they are not recognized: reporting |
skateman
changed the title
|
@himdel any idea why is this failing on yarn? |
|
Checked commits skateman/manageiq-ui-classic@7e8cdfc~...7e2065c with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 app/helpers/application_helper/toolbar/compare_view.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most cases of PDF generation were very similar to the way we do it with the widgets so I am generalizing the feature more. Hovewer, the saved report PDFs are generated by the backend as an asynchronous task, so they aren't covered by this PR.
@miq-bot add_label gaprindashvili/no, reporting, enhancement
@miq-bot add_reviewer @epwinchell
@miq-bot add_reviewer @martinpovolny
Related issue: #4113
https://bugzilla.redhat.com/show_bug.cgi?id=1588072