Use fonticons and proper tooltips in policy simulation quadrants #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
commented
Jun 8, 2018
app/helpers/quadicon_helper.rb
Outdated
| when true | ||
| {:fonticon => 'pficon pficon-ok', :tooltip => _('Policy simulation successful.')} | ||
| when 'N/A' | ||
| {:fonticon => nil, :tooltip => _('Policy simulation not applicable.')} # TODO: add an N/A fonticon |
skateman
force-pushed
the
policy-sim-quadrant
branch
3 times, most recently
from
37b111b to
edaee62
Compare
skateman
changed the title
skateman
force-pushed
the
policy-sim-quadrant
branch
from
edaee62 to
6ef52a2
Compare
epwinchell
approved these changes
Jun 11, 2018
skateman
changed the title
skateman
force-pushed
the
policy-sim-quadrant
branch
from
6ef52a2 to
11c2132
Compare
|
Checked commit skateman@11c2132 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy simulation results are always being displayed in the bottom right quadrant on a policy simulation screen. I'm changing all the old PNG fileicons to be fonticons and also updating the tooltips to be more descriptive.
Parent issue: #4051
@miq-bot add_label technical debt, graphics, gaprindashvili/no
@miq-bot add_reviewer @epwinchell