Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Request Info for Catalog Items #4082

Conversation

ZitaNemeckova
Copy link
Contributor

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584172

Data was never copied from session to @options when miq_request/prov_field_changed?tab_id=* request was fired

Services -> Catalogs -> Catalog Items -> choose any item with Request Info -> click Request Info -> click any tab in Request Info

Before:
screen shot 2018-06-07 at 2 11 27 pm

Console:

FATAL -- : Error caught: [NoMethodError] undefined method `[]=' for nil:NilClass
/manageiq-ui-classic/app/controllers/application_controller/miq_request_methods.rb:16:in `prov_field_changed'
/usr/local/lib/ruby/gems/2.3.0/gems/actionpack-5.0.7/lib/action_controller/metal/basic_implicit_render.rb:4:in `send_action'
/usr/local/lib/ruby/gems/2.3.0/gems/actionpack-5.0.7/lib/abstract_controller/base.rb:188:in `process_action'

After:
screen shot 2018-06-07 at 2 07 11 pm

@miq-bot add_label bug, services

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1584172

Data was never copied from session to @options when miq_request/prov_field_changed?tab_id=* request was fired
@ZitaNemeckova ZitaNemeckova force-pushed the get_options_in_miq_request_controller branch from 96c5dc3 to 3ac17d4 Compare June 7, 2018 12:33
@miq-bot
Copy link
Member

miq-bot commented Jun 7, 2018

Checked commit ZitaNemeckova@3ac17d4 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec self-assigned this Jun 8, 2018
@mzazrivec mzazrivec added this to the Sprint 88 Ending Jun 18, 2018 milestone Jun 8, 2018
@mzazrivec mzazrivec merged commit c655471 into ManageIQ:master Jun 8, 2018
@ZitaNemeckova ZitaNemeckova deleted the get_options_in_miq_request_controller branch June 14, 2018 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants