Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add missing info about unavailable fields while adding/editing Report #4081

Closed

Conversation

hstastna
Copy link

@hstastna hstastna commented Jun 7, 2018

Partially fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1581817

Depends on:
ManageIQ/manageiq#17501


What:
When choosing Chargeback for Images/Projects/Vms under Configure Report Columns section while adding a new/editing an existing Report under Cloud Intel > Reports > Reports, some of the fields are not available. This is ok but there was a misunderstanding that those fields were missing there. This is why I add note/info about which fields are not supported to the Report editing screen (in this PR), and also new selector for Chargeback Rate editing screen (under Cloud Intel > Chargeback > Rates) is added to choose what the Rate is based on (Images/Projects/Vms) (other PR: #4001). We call it the base model (see ManageIQ/manageiq-schema#209).


Before:
Choosing Chargeback for Images while adding/editing report:
images_before
Choosing Chargeback for Projects:
projects_before
Choosing Chargeback for Vms:
vms_before

After:
Choosing Chargeback for Images while adding/editing report:
images-after
Choosing Chargeback for Projects:
projects-after
Choosing Chargeback for Vms:
vms-after

@hstastna
Copy link
Author

hstastna commented Jun 7, 2018

@miq-bot add_label bug

@miq-bot miq-bot added the bug label Jun 7, 2018
@hstastna hstastna changed the title Add missing info about unavailable fields while adding/editing Report [WIP] Add missing info about unavailable fields while adding/editing Report Jun 7, 2018
@miq-bot miq-bot added the wip label Jun 7, 2018
@hstastna
Copy link
Author

hstastna commented Jun 7, 2018

@martinpovolny @mzazrivec Could you please look at this PR? Thanks! :)

@hstastna hstastna force-pushed the Add_info_unavailable_fields_Report branch from 7f2a918 to 9ac93a9 Compare June 13, 2018 11:04
@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2018

Checked commit hstastna@9ac93a9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@miq-bot
Copy link
Member

miq-bot commented Apr 1, 2019

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants