[GAPRINDASHVILI] API transformRequest support + http service #4005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced as part of #3662 in master to support v2v expecting every response wrapped in {data:...}
This was referenced May 30, 2018
Merged
Closed
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/a0c4a67cb8aa659e7aea042adb428a3fbdb92f81~...53f4df1a693411d1de5bbaa197c067f1031886da with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a gaprindasvhili version of #3662 and #3978.
Differences:
The master change lives under
app/javascript, written in ES6, and refactored so that the http vs API parts are much more separate. For gaprindashvili, leaving in ES5 with the minimal amount of changes to support both.Additional difference: changes that make the error modal distinguish between API and http requests were not backported, this means
httpaccess errors will appear as API errors in the error modal - this is just about the modal title, the URL fits.