Hide "Add New Network Manager" unless Nuage is enabled

[miha-plesko]

Nuage is somewhat special in a way it allows adding NetworkManager directly, without CloudManager. For all other providers such behavior is not feasible, therefore "Add New Network Manager" button should be hidden.

With this commit we make sure that the button is hidden unless config/permissions.yaml file contains entry allowing user to use Nuage provider:

- ems-type:nuage_network

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1577888

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @blomquisg

/cc @djberg96

[miha-plesko]

@djberg96 apologies for the troubles because we didn't think of this scenario when we flipped product: nuage to true.

[miq-bot]

Checked commit miha-plesko@85e559e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

[djberg96]

Won't this always return true by default as well? Or are users expected to remove it?

# On my local rails console:
irb(main):001:0> Vmdb::PermissionStores.instance.supported_ems_type?('nuage_network')
=> true

[miha-plesko]

It's the other way around: by default the config/permissions.yaml is very modest in CFME appliances. User then needs to manually enable additional providers e.g. Nuage provider. MIQ appliances, however, contain no config/permissions.yaml file at all and therefore return true for all permissions. So if you're on MIQ appliance, also this will yield true:

Vmdb::PermissionStores.instance.supported_ems_type?('blah blah blah')

(unless you add permissions.yaml on your own)

😄

[djberg96]

👍

[miha-plesko]

@blomquisg @juliancheal would you agree that UI should check config/permissions.yaml in order to decide whether "Add a New Network Provider" button is to be visible?

[juliancheal]

👍 LGTM