Reload classifications when adding or editing the tag expression for groups #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miq-bot add_label bug |
|
@miq-bot add_label settings, gaprindashvili/yes |
lgalis
force-pushed
the
get_new_classifications_on_add_edit_group
branch
from
6ea1057 to
4f3be07
Compare
lgalis
changed the title
|
@h-kataria - please review |
lgalis
force-pushed
the
get_new_classifications_on_add_edit_group
branch
from
4f3be07 to
3b6f0bb
Compare
|
Checked commit lgalis@3b6f0bb with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
simaishi
pushed a commit
that referenced
this pull request
Jul 11, 2018
…dit_group Reload classifications when adding or editing the tag expression for groups (cherry picked from commit 60c8b89) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1591495
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reload classifications when adding or editing the tag expression for groups
Depends on ManageIQ/manageiq#17465
Links
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1579867
Use the :no_cache option added in ManageIQ/manageiq#17465 in order for the new tags added to be displayed in the expression drop-down, rather than the cached list of tags.