Fix Save button which wasn't responding while editing Chargeback Rate #3974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue: ManageIQ#3961 Fix Save button which was not responding for currencies changes while editing Chargeback Rate, under Cloud Intel > Chargeback > Rates accordion > Compute/Storage Chargeback Rates.
|
Checked commit hstastna@70820ae with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@hstastna is this gaprindashvili/yes ? |
|
@mzazrivec Not sure. But if yes, we will need to create a BZ to backport it. |
|
@miq-bot add_label gaprindashvili/yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1583175
Issue with more info: #3961
Fix Save button which was not responding for Currencies' changes while editing Chargeback
Rate, under Cloud Intel > Chargeback > Rates accordion > Compute/Storage Chargeback Rates.
Original Chargeback Rate (just started editing; see the Currencies):
The currency was changed and Save button was enabled:
Before:
Currency changed back to the original value and Save button still enabled which is wrong:
After:
Currency changed back to the original value and Save button was disabled which is right:
Steps to reproduce:
=> Save button remains enabled (blue) even if we did not make any change comparing to the original currencies' values
Notes:
The problem was happening only while changing Currencies. Changing other values with enabling/disabling Save button seemed to work ok. Clicking on Reset button could fix the problem with Save button (after resetting the changes, Save button remained disabled which is right).
Details:
The core of the problem were:
edit[:new][:currency]was not set to the new value, when changing the currency, so:https://github.com/ManageIQ/manageiq-ui-classic/pull/3974/files#diff-1b26f16afe1a647952df7cc1637f4394R557
https://github.com/ManageIQ/manageiq-ui-classic/pull/3974/files#diff-1b26f16afe1a647952df7cc1637f4394R566
@edit[:new][:currency]and@edit[:current][:currency]were set to integers, but later,@edit[:new][:currency]was changed to string typeComparing the old vs. new values is happening here: https://github.com/ManageIQ/manageiq-ui-classic/pull/3974/files#diff-1b26f16afe1a647952df7cc1637f4394R183