mapping.tag is a category Tag, calling .category is ill-defined

[cben]

There are category/entry Tags, and category/entry Classifications.
.category is supposed to get the "uncle", the category Classification from an entry Tag:

                                   .parent
 category Classification "cat"   <----------   entry Classification "ent"
           |^                ^                        |^
       .tag||.classification  \_______________    .tag||.classification
           v|                     .category   \       v|
 category Tag /managed/cat                     entry Tag /managed/cat/ent

mapping.tag is a category Tag (for any-value mappings which are the kind we use).
Currently .category on a category Tag ("/managed/cat") happens to work same as .classification, but it's ill-defined and will stop working after ManageIQ/manageiq#17418.

@miq-bot add-label technical debt
@kbrock @Fryguy please review

[cben]

Locally I also see failures in ./spec/services/privilege_checker_service_spec.rb which sound unrelated (?), those also fail without ManageIQ/manageiq#17418.

[miq-bot]

Checked commits cben/manageiq-ui-classic@eb8e89f~...0d3c824 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[kbrock]

Good change.

the mapping's classification is the tag's category