Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React helper #3943

Merged
merged 2 commits into from
May 15, 2018
Merged

React helper #3943

merged 2 commits into from
May 15, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented May 15, 2018

Add a =react helper …

= react 'Foo'

creates an empty div, and initializes a react Foo component on it

params can be passed as a hash: = react 'Foo', {:bar => 5}

under the hood, this uses ManageIQ.component.componentFactory

@himdel
Copy link
Contributor Author

himdel commented May 15, 2018

Cc @Hyperkid123 , @martinpovolny , @karelhala

```
= react 'Foo'
```

creates an empty div, and initializes a react Foo component on it

params can be passed as a hash: `= react 'Foo', {:bar => 5}`

under the hood, this uses `ManageIQ.component.componentFactory`
@miq-bot
Copy link
Member

miq-bot commented May 15, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/35adc86ac05d1a8ea5054f9575fb7ab6f142423d~...03d353557f060831a4d1cd437965f9cd496b5f0b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🏆

@martinpovolny martinpovolny merged commit 8b0adbe into ManageIQ:master May 15, 2018
@martinpovolny martinpovolny self-assigned this May 15, 2018
@martinpovolny martinpovolny added this to the Sprint 86 Ending May 21, 2018 milestone May 15, 2018
@himdel himdel deleted the react-helper branch May 17, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants