Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to find tooltip column for charts where tooltip label not used. #3908

Merged

Conversation

yrudman
Copy link
Contributor

@yrudman yrudman commented May 7, 2018

Even Guest OS Information generated successfully and available, there is error in the log:
ERROR -- : MIQ(MiqReport#chart_header_column) The column for the chart's x-axis must be defined in the report when generating chart.

Fix: do not try to find label for tooltip in cases when this label not used

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565208

@miq-bot add-label bug

\cc @lpichler

@miq-bot miq-bot added the bug label May 7, 2018
@miq-bot
Copy link
Member

miq-bot commented May 7, 2018

Checked commit yrudman@e76e3d0 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🍰

Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to doesn't brake anything and fixes the BZ. LGTM 👍

@mzazrivec mzazrivec self-assigned this May 15, 2018
@mzazrivec mzazrivec added this to the Sprint 86 Ending May 21, 2018 milestone May 15, 2018
@mzazrivec mzazrivec merged commit 08abc7b into ManageIQ:master May 15, 2018
@yrudman yrudman deleted the do-not-find-tooltip-column-if-not-used branch May 15, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants