Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ansible Tower Service Catalog new item creation #3896

Conversation

GregP
Copy link
Contributor

@GregP GregP commented May 3, 2018

Fix code to check for required Provider and Job Template selections in the drop downs.

https://bugzilla.redhat.com/show_bug.cgi?id=1491772

Screen shot post code fix, for Ansible Tower catalog item, first check for required Provider in drop down selection, display error:
ansible service catalog item provider required post code fix

Once Provider is selected, then check for Job Template drop down selection, display error:
ansible service catalog item job template required post code fix

Record saved when both are present:
ansible service catalog item created post code fix

====

For Orchestration Catalog Items, order of checks is reversed, first verify that Template has been selected in the drop down:
orchestration catalog item require orchestration template code fix

Then check for Provider to be selected:
ansible service catalog item provider required post code fix

Saved Orchestration Catalog Item once both Template and Provider have been selected:
orchestration catalog item saved with both provider and template

@GregP GregP changed the title Fixes Ansible Tower Service Catalog new item creation [WIP] Fix Ansible Tower Service Catalog new item creation May 3, 2018
@GregP
Copy link
Contributor Author

GregP commented May 3, 2018

@miq-bot add_label fine

@miq-bot
Copy link
Member

miq-bot commented May 3, 2018

@GregP Cannot apply the following label because they are not recognized: fine

@GregP
Copy link
Contributor Author

GregP commented May 3, 2018

@miq-bot add_label gaprindashvili

@miq-bot
Copy link
Member

miq-bot commented May 3, 2018

@GregP Cannot apply the following label because they are not recognized: gaprindashvili

@miq-bot miq-bot added the wip label May 3, 2018
@GregP GregP force-pushed the service_catalog_ansible_item_provider_required branch from a72c9ba to 8b77c67 Compare May 4, 2018 15:26
@GregP GregP closed this May 7, 2018
@GregP GregP reopened this May 7, 2018
@GregP GregP force-pushed the service_catalog_ansible_item_provider_required branch from 8b77c67 to 0f6c767 Compare May 7, 2018 21:59
@GregP GregP closed this May 7, 2018
@GregP GregP reopened this May 7, 2018
@GregP GregP force-pushed the service_catalog_ansible_item_provider_required branch from 0f6c767 to 75d7f40 Compare May 8, 2018 21:49
Checks for required Provider and Job Template selections in the drop downs

https://bugzilla.redhat.com/show_bug.cgi?id=1491772
@GregP GregP force-pushed the service_catalog_ansible_item_provider_required branch from 75d7f40 to 7df1fc7 Compare May 8, 2018 21:51
@miq-bot
Copy link
Member

miq-bot commented May 8, 2018

Checked commit GregP@7df1fc7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 2 offenses detected

app/controllers/catalog_controller.rb

@GregP GregP changed the title [WIP] Fix Ansible Tower Service Catalog new item creation Fix Ansible Tower Service Catalog new item creation May 8, 2018
@miq-bot miq-bot removed the wip label May 8, 2018
@h-kataria h-kataria added this to the Sprint 86 Ending May 21, 2018 milestone May 10, 2018
@h-kataria h-kataria merged commit 6613eeb into ManageIQ:master May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants