Change @edit[:new][:timer_typ] to @edit[:new][:timer].typ #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no :time_typ key in @edit[:new] so it's aways nil and select is set to Hourly as it's the first value Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564199
|
Checked commit ZitaNemeckova@ff81db6 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Aah, makes sense, introduced in ManageIQ/manageiq#7739 (it used to be (Not sure whether this really needs to go in euwe or darga, but the bug should be present there.) |
|
The bug is not really present in Configuration since that editor was rewritten to angular, without the rest. Verified this fixes it in the other places 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no
:timer_typkey in@edit[:new]so it's awaysniland select is set to Hourly as it's the first value.Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1564199
Cloud Intel -> Reports -> Dashboard Widgets -> choose one that hasn't timer set to Hourly -> Edit
Cloud Intel -> Reports -> Schedules -> choose one that hasn't timer set to Hourly -> Edit
Configuration -> Settings -> Schedules -> choose one that hasn't timer set to Hourly -> Edit
Before:
After:
@miq-bot add_label bug, gaprindashvili/yes, cloud intel/reporting