Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable credential / repository form when embedded ansible is unavailable #3840

Conversation

mzazrivec
Copy link
Contributor

  1. Create a new role, new group using that role and a new user using that group
  2. Set the group restriction to one specific tag (edit the newly created group, assign filters, select one tag)
  3. With the new user, navigate to Automation -> Ansible -> Credentials
  4. Click on Add new Credential

Before:
ansible-before

After:
ansible-after

I also disabled the repository inputs for similar case.

@himdel review please?

https://bugzilla.redhat.com/show_bug.cgi?id=1560527

@miq-bot
Copy link
Member

miq-bot commented Apr 25, 2018

Checked commit mzazrivec@5880a30 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 1 offense detected

**

  • 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:
warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

@himdel himdel self-assigned this Apr 26, 2018
@himdel
Copy link
Contributor

himdel commented Apr 26, 2018

LGTM, mostly matches what's happening in repositories.

(I would not go so far as to disable every single input in the form, that's a first in ui-classic, but.. why not.)

@himdel himdel merged commit 6ee8f69 into ManageIQ:master Apr 26, 2018
@himdel himdel added this to the Sprint 85 Ending May 7, 2018 milestone Apr 26, 2018
@mzazrivec mzazrivec deleted the disable_embedded_ansible_credential_form_when_manager_unavailable branch April 26, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants