Fix title in Config Settings page to match the accordion #3819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1512443 Fix the title in the Configuration > Settings page when selecting Region0 in accordion, to match the name in the accordion.
|
@miq-bot add_label bug, gaprindashvili/yes |
|
Checked commit hstastna@47939e7 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1512443
Fix the title in the Configuration > Settings page when selecting ManageIQ Region (or CFME Region) in accordion, to match the name in the accordion.
Before:
Editing the region (after clicking on Region10[10] in the list, under the title):
After:
Editing the region:
Why I fixed this the way I fixed it:
See https://github.com/hstastna/manageiq-ui-classic/blob/master/app/presenters/tree_builder_ops_settings.rb#L18, especially the
product.