Fixes Service Catalog Item Custom subtype display

[GregP]

Fixes default display of "Custom" Service Catalog Item Subtype when value is not set upon creation/edit.

https://bugzilla.redhat.com/show_bug.cgi?id=1568471

Screen shot post code fix:

[GregP]

@miq-bot add-label gaprindashvili/yes

[GregP]

@miq-bot add-label fine/yes

[miq-bot]

Checked commit GregP@367af3f with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

**

• 💣 💥 🔥 🚒 - Linter/Haml - Linter::Haml STDERR:

warning: parser/current is loading parser/ruby23, which recognizes
warning: 2.3.6-compliant syntax, but you are running 2.3.3.
warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.

[mzazrivec]

ServiceTemplate::GENERIC_ITEM_SUBTYPES already contains "custom" => _("Custom"), so = h(ServiceTemplate::GENERIC_ITEM_SUBTYPES[@edit[:new][:generic_subtype]]) should render it, unless there's something else going on.

i.e. we should figure out why in this particular case (and maybe with that particular version) would the UI not see the custom subtype, rather than doing work arounds.

[GregP]

@mzazrivec Because one can create a Generic service without Subtype.

[mzazrivec]

@GregP How exactly can I create a generic catalog item without subtype?

[h-kataria]

@mzazrivec not sure how the customer got into that state, but this fix will just safeguard the scenario where user has old Catalog Items with no subtype selected. We do the same in the Catalog Item edit form as well, where if it is not populated we default it to "custom"

[mzazrivec]

@h-kataria Can you please point me to the part of catalog item edit form code where we default the item subtype to custom? Thanks.

[h-kataria]

@mzazrivec https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/catalog_controller.rb#L1319

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 074687b90a5eeb3751be81efe7a4d773f2d48bcc
Author: Harpreet Kataria <[email protected]>
Date:   Mon Apr 23 11:07:12 2018 -0400

    Merge pull request #3809 from GregP/cat_item_custom_subtype_display
    
    Fixes Service Catalog Item Custom subtype display
    (cherry picked from commit 1387e2aeee9955ea172c47437813a6d4213f9da9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1570989

[simaishi]

Fine backport details:

$ git log -1
commit c67ff60712d6680120f4b4d22460fd19cd21b611
Author: Harpreet Kataria <[email protected]>
Date:   Mon Apr 23 11:07:12 2018 -0400

    Merge pull request #3809 from GregP/cat_item_custom_subtype_display
    
    Fixes Service Catalog Item Custom subtype display
    (cherry picked from commit 1387e2aeee9955ea172c47437813a6d4213f9da9)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1570990