Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CiProcessing specs - stub user for failing retirement specs #3792

Merged
merged 1 commit into from
Apr 18, 2018
Merged

CiProcessing specs - stub user for failing retirement specs #3792

merged 1 commit into from
Apr 18, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Apr 18, 2018

Fixes failing travis:

Failures:
  1) VmOrTemplateController#vm_button_operation should continue to retire a vm
     Failure/Error:
       expect(assigns(:flash_array).first[:message]).to \
         include("Retirement initiated for 1 VM and Instance from the %{product} Database" % {:product => Vmdb::Appliance.PRODUCT_NAME})

       expected "Error during 'retire_now': undefined method `userid' for nil:NilClass" to include "Retirement initiated for 1 VM and Instance from the ManageIQ Database"
     # ./spec/controllers/application_controller/ci_processing_spec.rb:942:in `block (3 levels) in <top (required)>'
  2) ServiceController#vm_button_operation should continue to retire a service and does not render flash message 'xxx does not apply xxx'
     Failure/Error:
       expect(assigns(:flash_array).first[:message]).to \
         include("Retirement initiated for 1 Service from the %{product} Database" % {:product => Vmdb::Appliance.PRODUCT_NAME})

       expected "Error during 'retire_now': undefined method `userid' for nil:NilClass" to include "Retirement initiated for 1 Service from the ManageIQ Database"
     # ./spec/controllers/application_controller/ci_processing_spec.rb:874:in `block (3 levels) in <top (required)>'

Looks like this is related to the recent make_request changes in ManageIQ/manageiq#17255 - Cc @d-m-u

Fixes:

    Failures:
      1) VmOrTemplateController#vm_button_operation should continue to retire a vm
         Failure/Error:
           expect(assigns(:flash_array).first[:message]).to \
             include("Retirement initiated for 1 VM and Instance from the %{product} Database" % {:product => Vmdb::Appliance.PRODUCT_NAME})

           expected "Error during 'retire_now': undefined method `userid' for nil:NilClass" to include "Retirement initiated for 1 VM and Instance from the ManageIQ Database"
         # ./spec/controllers/application_controller/ci_processing_spec.rb:942:in `block (3 levels) in <top (required)>'
      2) ServiceController#vm_button_operation should continue to retire a service and does not render flash message 'xxx does not apply xxx'
         Failure/Error:
           expect(assigns(:flash_array).first[:message]).to \
             include("Retirement initiated for 1 Service from the %{product} Database" % {:product => Vmdb::Appliance.PRODUCT_NAME})

           expected "Error during 'retire_now': undefined method `userid' for nil:NilClass" to include "Retirement initiated for 1 Service from the ManageIQ Database"
         # ./spec/controllers/application_controller/ci_processing_spec.rb:874:in `block (3 levels) in <top (required)>'
@miq-bot
Copy link
Member

miq-bot commented Apr 18, 2018

Checked commit https://github.com/himdel/manageiq-ui-classic/commit/f58015b1777b5093e2cc9240662bf74fe530f375 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 🏆

@mzazrivec mzazrivec added this to the Sprint 84 Ending Apr 23, 2018 milestone Apr 18, 2018
@mzazrivec mzazrivec merged commit e1a6be3 into ManageIQ:master Apr 18, 2018
@himdel himdel deleted the fix-retire-spec branch April 18, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants